Dev Eval
DashboardEngineersReposCommits
wishwish-contracts·2026-04-10·devin-ai-integration[bot]

fix: emit pre-increment nonce in CollectableMinted event and add zero-address owner check in init

74c5466e518d7c5737b19a72894b14c548ca1cb7View on GitHub
Lines Added
+2
Lines Deleted
-2
Files Changed
1
Committed At
2026-04-10 20:19:56
Message
- CollectableMinted event was emitting the post-increment nonce (nonce+1)
  instead of the nonce actually used for EIP-712 signature verification.
  This caused off-chain systems to see a nonce value that didn't match the
  signed payload, breaking event-to-signature correlation.

- init() validated _platformRoyaltyReceiver for zero address but not _owner.
  Since _guardInitializeOwner is not overridden, Solady's _initializeOwner
  does not guard against double-init. Passing address(0) as _owner would
  leave the protocol without an owner and the init guard bypassable.

Co-Authored-By: Xingyu Li <72717104+0xlxy@users.noreply.github.com>
Reachable From
Branches that include this commit at the time of last fetch
devin/1775852277-fix-nonce-event-and-init-validation